lightning: recover status from checkpoint after index engine closed

[lance6716]

Signed-off-by: lance6716 [email protected]

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

pingcap/tiflow#7702 (comment)

What is changed and how it works?

Seems in all logic, both tidb backend and local backend, we treat data or data engine write to TiKV as finished. So when recover from checkpoint, if the whole table fails after finish data part and we are resumed from checkpoint, add all data size to finished size

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• D3Hunter
• okJiang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[lance6716]

/cc @D3Hunter @okJiang

[okJiang]

fix here? https://github.com/pingcap/tiflow/blob/e0bce5e400144a499ae08f39f4eae7ba3f2f38e1/engine/test/integration_tests/dm_full_mode/run.sh#L67-L68

[lance6716]

fix here? https://github.com/pingcap/tiflow/blob/e0bce5e400144a499ae08f39f4eae7ba3f2f38e1/engine/test/integration_tests/dm_full_mode/run.sh#L67-L68

yes

[okJiang]

fix here? pingcap/tiflow@e0bce5e/engine/test/integration_tests/dm_full_mode/run.sh#L67-L68

yes

But you still kept this TODO. Please remove it in this pr.

[lance6716]

fix here? pingcap/tiflow@e0bce5e/engine/test/integration_tests/dm_full_mode/run.sh#L67-L68

yes

But you still kept this TODO. Please remove it in this pr.

that's two repo, tidb and tiflow

[okJiang]

fix here? pingcap/tiflow@e0bce5e/engine/test/integration_tests/dm_full_mode/run.sh#L67-L68

yes

But you still kept this TODO. Please remove it in this pr.

that's two repo, tidb and tiflow

I am sorry I mixed them😂.

[okJiang]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 180951f

[lance6716]

/merge

[hawkingrei]

/run-all-tests

[lance6716]

/merge

[lance6716]

/run-integration-br-tests

[lance6716]

/merge

[sre-bot]

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name	Result	Duration	Compare with Parent commit
idc-jenkins-ci-tidb/mybatis-test	🔴 failed 1, success 0, total 1	11 min	Existing failure
idc-jenkins-ci/integration-cdc-test	🟢 all 39 tests passed	20 min	Existing passed
idc-jenkins-ci-tidb/integration-common-test	🟢 all 17 tests passed	16 min	Existing passed
idc-jenkins-ci-tidb/common-test	🟢 all 11 tests passed	10 min	Existing passed
idc-jenkins-ci-tidb/integration-ddl-test	🟢 all 6 tests passed	7 min 53 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2	🟢 all 28 tests passed	6 min 13 sec	Existing passed
idc-jenkins-ci-tidb/tics-test	🟢 all 1 tests passed	6 min 2 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1	🟢 all 26 tests passed	5 min 14 sec	Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test	🟢 all 1 tests passed	3 min 33 sec	Existing passed
idc-jenkins-ci-tidb/plugin-test	🟢 build success, plugin test success	4min	Existing passed