Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log-backup: directly override the exists file when do truncate on gcs or azure #38232

Merged
merged 6 commits into from
Oct 10, 2022
Merged

log-backup: directly override the exists file when do truncate on gcs or azure #38232

merged 6 commits into from
Oct 10, 2022

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Sep 28, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #38229

Problem Summary:
the file on gcs or azure can be directly override when there is another file uploaded with the same name.

What is changed and how it works?

override the exists file when do truncate on gcs or azure.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • joccau

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Sep 28, 2022
@Leavrth
add unit test
b7371b7 
Signed-off-by: Leavrth <[email protected]>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 29, 2022
@3pointer
Copy link
Contributor

/run-unit-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 30, 2022
joccau
joccau reviewed Oct 10, 2022
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

br/pkg/restore/stream_metas_test.go Show resolved Hide resolved
joccau
joccau approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 10, 2022
@Leavrth
Copy link
Contributor Author

Leavrth commented Oct 10, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 12aff12

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 10, 2022
@ti-chi-bot ti-chi-bot merged commit e0cfba6 into pingcap:master Oct 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 10, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 10 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 29 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 29 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 9 min 50 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 14 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 46 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 3 min 33 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 54 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 45 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Leavrth added a commit to Leavrth/tidb that referenced this pull request Nov 8, 2022
@Leavrth
log-backup: directly override the exists file when do truncate on gcs…
da8ffc4 
… or azure (pingcap#38232)

close pingcap#38229
@Leavrth Leavrth deleted the override_when_truncate_for_gcs_or_azure branch January 30, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

@joccau joccau joccau approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

log-backup: failed to truncate the log data on gcs or azure blob
6 participants
@Leavrth @ti-chi-bot @3pointer @sre-bot @YuJuncen @joccau