-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: support single precision value in json agg #37389
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/820eaa65f5caa37aaa9d8aefe9b76aca83685683 |
This comment was marked as resolved.
This comment was marked as resolved.
please add the manual test into the test file |
Signed-off-by: YangKeao <[email protected]>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: cfa5c01
|
TiDB MergeCI notify🔴 Bad News! [2] CI still failing after this pr merged.
|
Signed-off-by: YangKeao [email protected]
What problem does this PR solve?
Issue Number: close #37287
Problem Summary:
The
json_objectagg
andjson_arrayagg
can receive float now 🍻 .What is changed and how it works?
Convert the float value into double before writing into the map. I also moved the validation/conversion of data type from
AppendFinalResult2Chunk
toUpdatePartialResult
, which will make it find the problem or convert the data ASAP.Check List
Tests
It gives
Release note