-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log-backup: Refactor daemon #36763
log-backup: Refactor daemon #36763
Conversation
Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: Yu Juncen <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/fa86866c2975fb51b16f0be24d966a0ae2bc1335 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 49fb9e6
|
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #36762
Problem Summary:
See the issue.
What is changed and how it works?
The
AdvancerDaemon
has been refactored, now, it would be carried by a new typeOwnerDaemon
, which supports the callbackOnBegin
.Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.