-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/copr: set a smaller channel size for coprocessor task in the keep order case #36047
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/4d4b58d6900e7945bf4d909da710533fb78fb9e1 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 90caf8c
|
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #36041
Problem Summary:
What is changed and how it works?
Channel size 128 is too large and in
select ... order by _tidb_rowid
query, a lot of coprocessor response packetis cached in the channel, consume much more memory than necessary.
Set a smaller channel size, the performance is basically the same ... the memory usage reduce dramatically
Channel size = 2~8 takes 2min25 ~2min30, although memory usage is low, performance decrease b.t.w
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.