Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/copr: set a smaller channel size for coprocessor task in the keep order case #36047

Merged
merged 3 commits into from
Jul 14, 2022

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #36041

Problem Summary:

What is changed and how it works?

Channel size 128 is too large and in select ... order by _tidb_rowid query, a lot of coprocessor response packet
is cached in the channel, consume much more memory than necessary.

Set a smaller channel size, the performance is basically the same ... the memory usage reduce dramatically

Channel size = 16
time mysql -h 127.0.0.1 -u root -P 4000 -B ens_rb -e 'set @@tidb_enable_paging = 1; select * FROM `ens_rb003`.`rb_acct_int_detail` order by _tidb_rowid' > /dev/null
real        2m2.946s
user        0m58.253s
sys        0m4.552s

Channel size = 128
genius@genius-System-Product-Name:~/project/src/github.com/pingcap/tidb$ time mysql -h 127.0.0.1 -u root -P 4000 -B ens_rb -e 'set @@tidb_enable_paging = 1; select * FROM `ens_rb003`.`rb_acct_int_detail` order by _tidb_rowid' > /dev/null
real        1m57.945s
user        0m57.367s
sys        0m4.701s

Channel size = 18
genius@genius-System-Product-Name:~/project/src/github.com/pingcap/tidb$ time mysql -h 127.0.0.1 -u root -P 4000 -B ens_rb -e 'set @@tidb_enable_paging = 1; select * FROM `ens_rb003`.`rb_acct_int_detail` order by _tidb_rowid' > /dev/null
real        1m59.419s
user        0m57.893s
sys        0m4.581s

image

Channel size = 2~8 takes 2min25 ~2min30, although memory usage is low, performance decrease b.t.w

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Set a smaller channel size for coprocessor task, in the full table scan 'order by' case, this change can reduce memory usage for the coprocessor paging protocol.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 8, 2022
@tiancaiamao tiancaiamao marked this pull request as ready for review July 8, 2022 08:34
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 8, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 8, 2022

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 13, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 13, 2022
@tiancaiamao
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 90caf8c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2022
@ti-chi-bot ti-chi-bot merged commit 5406793 into pingcap:master Jul 14, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 14, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test ✅ all 36 tests passed 24 min Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 39 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 45 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 30 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 32 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 16 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 51 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@tiancaiamao tiancaiamao deleted the chan-size branch July 14, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coprocessor request with projection and order by takes too much memory
5 participants