-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/copr: set low concurrency for keep order coprocessor requests #35975
store/copr: set low concurrency for keep order coprocessor requests #35975
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Testing with non-paging protocol, the conclusion is the same, high concurrency is useless here.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8f6ab49
|
@tiancaiamao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-unit-test |
/hold |
/run-unit-test |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/74edaebe3e418a34515791a805320c2bc488204b |
/run-check_dev_2 |
1 similar comment
/run-check_dev_2 |
/unhold |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 74edaeb
|
What problem does this PR solve?
Issue Number: close #35974
Problem Summary:
keep order requests consume much more memory than normal cases.
That's because we use a high coprocessor concurrency for it, but with the existance of 'order by',
the cop responses have to be handled one by one ... most of the cop responses are just wasting memory.
What is changed and how it works?
We don't need high concurrency for keep order coprocessor requests.
=====================
The performance do not decrease with lower concurrency!
Before:
After:
=====================
The memory consumption reduced:
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.