executor: fix dead loop for indexMergeJoin in paging. #35918
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/e860dc286cd7317e90cb90b14d0f6eb37d58d0f5 |
executor/builder.go
Outdated
| @@ -3873,6 +3873,12 @@ func (builder *dataReaderBuilder) buildTableReaderForIndexJoin(ctx context.Conte | |||
| lookUpContents []*indexJoinLookUpContent, indexRanges []*ranger.Range, keyOff2IdxOff []int, | |||
| cwc *plannercore.ColWithCmpFuncManager, canReorderHandles bool, memTracker *memory.Tracker, interruptSignal *atomic.Value) (Executor, error) { | |||
| e, err := buildNoRangeTableReader(builder.executorBuilder, v) | |||
| if !canReorderHandles { | |||
| // If we can't reorder handles, the kvRange maybe not ordered. The test case(see issue35831) for IndexMergeJoin will fail. | |||
There was a problem hiding this comment.
`canReorderHandles` is set to false only in IndexMergeJoin. IndexMergeJoin will trigger a dead loop problem when enabling paging(tidb/issues/35831). But IndexMergeJoin is not visible to the user and is deprecated for now. Thus we disable paging here.
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: f19c5c0
|
ti-chi-bot
added
the
status/can-merge
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #35831
Problem Summary:
What is changed and how it works?
Close paging protocol for indexMergeJoin request.
Check List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
Test the issue 35831 in real tikv and pass.
No code
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.