-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix a nil point when @@tidb_enable_collect_execution_info is off and cop cache is on #35839
Conversation
…s off and cop cache is on
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/07bd00b6ea8e116400c425920bdc59181778beaa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TimeStamp: worker.req.StartTs, | ||
RegionID: task.region.GetID(), | ||
RegionDataVersion: resp.pbResp.CacheLastVersion, | ||
if resp.detail != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can move resp.detail != nil
into L960?
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1ba2a9f
|
/run-mysql-test |
1 similar comment
/run-mysql-test |
/run-build |
/run-mysql-test |
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
Signed-off-by: you06 <[email protected]> fix tests Signed-off-by: you06 <[email protected]> fix test Signed-off-by: you06 <[email protected]> update Signed-off-by: you06 <[email protected]> update bazel Signed-off-by: you06 <[email protected]> fix test Signed-off-by: you06 <[email protected]> fix test Signed-off-by: you06 <[email protected]> update Signed-off-by: you06 <[email protected]> update client-go Signed-off-by: you06 <[email protected]> update client-go Signed-off-by: you06 <[email protected]> update grafana Signed-off-by: you06 <[email protected]> update bazel Signed-off-by: you06 <[email protected]> display by stack Signed-off-by: you06 <[email protected]> set request source for ctx of Signed-off-by: you06 <[email protected]> address comment Signed-off-by: you06 <[email protected]> address comment Signed-off-by: you06 <[email protected]> parser, ddl: support decoding binary literal in set/enum (pingcap#35822) close pingcap#31338 executor: fix a nil point when @@tidb_enable_collect_execution_info is off and cop cache is on (pingcap#35839) close pingcap#35829 ddl: support drop columns for multi-schema change (pingcap#35737) ref pingcap#14766 planner: don't push down predicates over table dual (pingcap#35669) close pingcap#35527 *: Remove some useless staleness code (pingcap#35849) close pingcap#35848 ddl: fix potential wrong column definition when setting default value (pingcap#35845) close pingcap#35846 *: add timeout for test cases (pingcap#35844) ddl: remove `onDropColumns` and `onAddColumns` (pingcap#35862) ref pingcap#14766 *: Fix Dockerfile (pingcap#35835) close pingcap#35828 server: refactor TestConnExecutionTimeout (pingcap#35865) close pingcap#35868 fix test Signed-off-by: you06 <[email protected]> fix lint Signed-off-by: you06 <[email protected]>
What problem does this PR solve?
Issue Number: close #35829
Problem Summary:
What is changed and how it works?
When
@@tidb_enable_collect_execution_info
is off, theresp.detail
is nilAnd when cop cache code use it in
resp.detail.TimeDetail.ProcessTime
, tidb get a nil point panic.Check List
Tests
Run the test case with real tikv
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.