-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: refine date_add/sub return type and precision #35009
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 020b32a
|
/run-mysql-test tidb-test=pr/1734 |
/rebuild |
1 similar comment
/rebuild |
/run-build |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.0 in PR #35444 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.1 in PR #35445 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.2 in PR #35446 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.3 in PR #35447 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.4 in PR #35448 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-6.0 in PR #35449 |
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #31799, close #9813. And part of #31867 will be resolved by this PR.
Problem Summary:
There exists several issues about function
date_add
anddate_sub
:date_add/sub(int/double/decimal, interval)
: MySQL returns string, TiDB returns datetime.date_add/sub(duration, interval)
when interval unit contains YMD part (except for DAY_MICROSECOND - I believe it's a mismatch between MySQL's actual behavior and its document, but it doesn't matter much), MySQL returns datetime with current date padded, TiDB returns time.--column-type-info
is your good friend.Honestly I can file 10+ bugs easily about the above issues.
What is changed and how it works?
Don't get scared of this huge PR - 90% are tests and 80% of which are generated, the core is quite simple. This PR includes the following changes:
expression/builtin_time.go
:date_add
anddate_sub
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.