Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: remove pingcap/check dependency #34734

Merged
merged 15 commits into from
May 17, 2022
Merged

*: remove pingcap/check dependency #34734

merged 15 commits into from
May 17, 2022

Conversation

tisonkun
Copy link
Contributor

Issue Number: close #28328

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels May 17, 2022
@tisonkun tisonkun marked this pull request as ready for review May 17, 2022 08:20
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 17, 2022
@tisonkun
Copy link
Contributor Author

/cc @hawkingrei @xhebox @lcwangchao @tangenta

@tisonkun tisonkun changed the title session: migrate test-infra to testify for session_test *: remove pingcap/check dependency May 17, 2022
tisonkun
tisonkun commented May 17, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2022
@tisonkun tisonkun requested a review from a team as a code owner May 17, 2022 09:22
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 17, 2022
tisonkun added 2 commits May 17, 2022 18:01
@tisonkun
workaround flags
5c37d57 
Signed-off-by: tison <[email protected]>
@tisonkun
fix test
1daac83 
Signed-off-by: tison <[email protected]>
@sre-bot
Copy link
Contributor

sre-bot commented May 17, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/311376729bc26ec2972e650d0e935ceaf43c3b92

@tisonkun
Copy link
Contributor Author

/cc @morgo @bb7133

@ti-chi-bot ti-chi-bot requested review from bb7133 and morgo May 17, 2022 10:56
bb7133
bb7133 approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Great work! @tisonkun , thank you for everything you have done.

@bb7133
Copy link
Member

bb7133 commented May 17, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cb605d0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2022
@ti-chi-bot ti-chi-bot merged commit 810f8ae into pingcap:master May 17, 2022
@tisonkun tisonkun deleted the issue-28328 branch May 17, 2022 13:41
@tisonkun tisonkun mentioned this pull request May 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@tangenta tangenta tangenta approved these changes

@bb7133 bb7133 bb7133 approved these changes

@lcwangchao lcwangchao Awaiting requested review from lcwangchao

@xhebox xhebox Awaiting requested review from xhebox

@morgo morgo Awaiting requested review from morgo

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for session/session_test.go
6 participants
@tisonkun @ti-chi-bot @sre-bot @bb7133 @hawkingrei @tangenta