-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: fix the issue that memory usage not released after tracker Detach #34592
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/3d50b91d989dc505e6846d487035cfdf11c343ae |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e93b23b
|
/run-mysql-test |
TiDB MergeCI notify
|
What problem does this PR solve?
Issue Number: ref #34571
Problem Summary:
What is changed and how it works?
We need the label to find children in the parent tracker
If we change the label after attach to some tracker, the tracker can't detach
tidb/util/memory/tracker.go
Lines 263 to 287 in 901f042
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.