Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

realtikvtest: dedicated package for real tikv tests #34361

Closed
wants to merge 9 commits into from
Closed

realtikvtest: dedicated package for real tikv tests #34361

wants to merge 9 commits into from

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented May 3, 2022

Issue Number: ref #28328

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 3, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 3, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 3, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a632acd2cf16003605900b5ac9258216819b659c

@tisonkun
Copy link
Contributor Author

tisonkun commented May 3, 2022

/run-check_dev_2

@tisonkun tisonkun closed this May 3, 2022
@tisonkun tisonkun deleted the issue-28328 branch May 3, 2022 09:55
@tisonkun tisonkun restored the issue-28328 branch May 3, 2022 11:28
@tisonkun tisonkun reopened this May 3, 2022
@hawkingrei
Copy link
Member

/run-check_dev_2

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 4, 2022
@hawkingrei hawkingrei requested a review from xhebox May 4, 2022 10:22
@tisonkun
Copy link
Contributor Author

tisonkun commented May 4, 2022

@hawkingrei this new workflow is very unstable due to the lack of resource on GitHub Actions. It'd be better to involve related developers for a better CI resource.

@xhebox
Copy link
Contributor

xhebox commented May 4, 2022

@hawkingrei this new workflow is very unstable due to the lack of resource on GitHub Actions. It'd be better to involve related developers for a better CI resource.

Agree.

@tisonkun
Copy link
Contributor Author

tisonkun commented May 4, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2022
@hawkingrei
Copy link
Member

@hawkingrei this new workflow is very unstable due to the lack of resource on GitHub Actions. It'd be better to involve related developers for a better CI resource.

I will try the self-hosts GitHub action to accelerate the ci tomorrow.

@tisonkun
Copy link
Contributor Author

tisonkun commented May 7, 2022

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented May 9, 2022

@hawkingrei any news about test resources?

@hawkingrei
Copy link
Member

@hawkingrei any news about test resources?

Wait for EE team after the holiday.

@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 9, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented May 9, 2022

@hawkingrei thanks for your information. Hope I don't have to fix more conflicts :)

@tisonkun
Copy link
Contributor Author

@hawkingrei @xhebox code updated. Waiting for PingCAP-QE/ci#953.

@tisonkun
Copy link
Contributor Author

/hold

While migrate in place, figure out how to deal with test-infra later.

@tisonkun tisonkun closed this May 11, 2022
@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2022
@tisonkun tisonkun reopened this May 11, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2022
@tisonkun
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 11, 2022
@tisonkun tisonkun closed this May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tisonkun @ti-chi-bot @sre-bot @hawkingrei @xhebox