Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: don't use chunk rpc protocol for internal session (#31723) #32344

Merged
merged 4 commits into from
Jun 15, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Feb 15, 2022

cherry-pick #31723 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/32344

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/32344:release-5.3-acc3ae622926

What problem does this PR solve?

Issue Number: close #30880

This is a workaround rather than a direct fix.

Problem Summary:

Chunk RPC protocol have the memory leak problem #30880

Before we figure out how it's happening and fix the bug, we can avoid using it for internal sessions.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

After avoiding using chunk RPC protocol for internal session, the memory usage is low.

./bin/dumpling  -h "172.16.5.59" -P "4897" -u "root" --output "s3://tmp/dumpling-outputc1144ef2-c669-4aea-8482-87b3ab6efbc2?access-key=XXXXXXX&secret-access-key=XXXXXXXX&endpoint= XXXXXXXX&force-path-style=true" --filetype "csv" --filesize "256M" --rows "200" --threads 4 --params "tidb_enable_chunk_rpc=0"
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 15, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 15, 2022
@ti-srebot ti-srebot added affects-5.4 This bug affects the 5.4.x(LTS) versions. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.3-cherry-pick type/bugfix This PR fixes a bug. labels Feb 15, 2022
@ti-srebot
Copy link
Contributor Author

@tiancaiamao you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 22, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 15, 2022
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2e87255

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 15, 2022

@ti-chi-bot ti-chi-bot merged commit f926183 into pingcap:release-5.3 Jun 15, 2022
@tiancaiamao tiancaiamao deleted the release-5.3-acc3ae622926 branch June 15, 2022 12:36
@heibaijian heibaijian added this to the v5.3.2 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.3-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants