-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: don't use chunk rpc protocol for internal session (#31723) #32344
*: don't use chunk rpc protocol for internal session (#31723) #32344
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@tiancaiamao you're already a collaborator in bot's repo. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2e87255
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/e9b8ecb3ff3c04f992f0a494e591b80c42ec83ae |
cherry-pick #31723 to release-5.3
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/32344
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #30880
This is a workaround rather than a direct fix.
Problem Summary:
Chunk RPC protocol have the memory leak problem #30880
Before we figure out how it's happening and fix the bug, we can avoid using it for internal sessions.
What is changed and how it works?
Check List
Tests
After avoiding using chunk RPC protocol for internal session, the memory usage is low.
Side effects
Documentation
Release note