-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix data race in the IndexNestedLoopHashJoin (#31731) #31756
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-all-tests |
@wshwsh12 you're already a collaborator in bot's repo. |
@wshwsh12 remainder~ |
Cherry-pick in #31448 since this data race is detected by the test case added in that commit. |
@ti-srebot: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cherry-pick #31731 to release-5.3
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/31756
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #31467
Problem Summary:
Enable failpoint and test race for the test TestIssue31129, it will failed.
What is changed and how it works?
handleTask
will handle the error when keepOuterOrder is true.We shouldn't handle it again.
Check List
Tests
Side effects
Documentation
Release note