Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: don't use chunk rpc protocol for internal session #31723

Merged
merged 13 commits into from
Jan 18, 2022
Merged

*: don't use chunk rpc protocol for internal session #31723

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
785fc51
*: don't use chunk rpc protocol for internal session
tiancaiamao Jan 17, 2022
dd04594
add code comment
tiancaiamao Jan 17, 2022
091e6e8
Merge branch 'master' into use-chunk-rpc
ti-chi-bot Jan 17, 2022
c2d469f
Merge branch 'master' into use-chunk-rpc
ti-chi-bot Jan 17, 2022
ee4ff40
Merge branch 'master' into use-chunk-rpc
ti-chi-bot Jan 17, 2022
dfb97ad
Merge branch 'master' into use-chunk-rpc
hawkingrei Jan 17, 2022
79568b9
Merge branch 'master' into use-chunk-rpc
ti-chi-bot Jan 17, 2022
4be27d4
Merge branch 'master' into use-chunk-rpc
ti-chi-bot Jan 17, 2022
6bde495
Merge branch 'master' into use-chunk-rpc
hawkingrei Jan 17, 2022
08f976f
Merge branch 'master' into use-chunk-rpc
ti-chi-bot Jan 17, 2022
3a19b6c
Merge branch 'master' into use-chunk-rpc
hawkingrei Jan 17, 2022
66cfef5
Merge branch 'master' into use-chunk-rpc
ti-chi-bot Jan 17, 2022
a75b760
Merge branch 'master' into use-chunk-rpc
ti-chi-bot Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions session/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,6 +1134,9 @@ func createSessionFunc(store kv.Storage) pools.Factory {
}
se.sessionVars.CommonGlobalLoaded = true
se.sessionVars.InRestrictedSQL = true
// TODO: Remove this line after fixing https://github.com/pingcap/tidb/issues/30880
// Chunk RPC protocol may have memory leak issue not solved.
se.sessionVars.EnableChunkRPC = false
return se, nil
}
}
Expand All @@ -1154,6 +1157,9 @@ func createSessionWithDomainFunc(store kv.Storage) func(*domain.Domain) (pools.R
}
se.sessionVars.CommonGlobalLoaded = true
se.sessionVars.InRestrictedSQL = true
// TODO: Remove this line after fixing https://github.com/pingcap/tidb/issues/30880
// Chunk RPC protocol may have memory leak issue not solved.
se.sessionVars.EnableChunkRPC = false
return se, nil
}
}
Expand Down