Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix wrong result for join with enum type (#29375) #29515

Merged
merged 15 commits into from
Apr 13, 2022
Merged

executor: fix wrong result for join with enum type (#29375) #29515

merged 15 commits into from
Apr 13, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 5, 2021 •
edited
Loading

cherry-pick #29375 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/29515

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/29515:release-5.2-fa8cbd588836

What problem does this PR solve?

Issue Number: close #27831

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix wrong result for join with enum type

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 5, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • ichn-hu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 5, 2021
@ti-srebot ti-srebot mentioned this pull request Nov 5, 2021
Merged
12 tasks
@ti-srebot ti-srebot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.2-cherry-pick labels Nov 5, 2021
@ti-srebot ti-srebot added this to the v5.2.2 milestone Nov 5, 2021
@ti-srebot
Copy link
Contributor Author

@wshwsh12 you're already a collaborator in bot's repo.

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 11, 2022
@wshwsh12 wshwsh12 force-pushed the release-5.2-fa8cbd588836 branch from c0a18b1 to 37494f5 Compare April 11, 2022 07:50
@wshwsh12
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 12, 2022
@wshwsh12
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c77740f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 12, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/d35dea382395bc73fbe14712be5e63610fc0d9bf

@hawkingrei
Copy link
Member

/run-unit-test

@wshwsh12
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit fb4741d into pingcap:release-5.2 Apr 13, 2022
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.2.2, v5.2.4 Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@ichn-hu ichn-hu ichn-hu approved these changes

@guo-shaoge guo-shaoge Awaiting requested review from guo-shaoge

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees

@wshwsh12 wshwsh12

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.2-cherry-pick
Projects
None yet
Milestone
v5.2.4
Development

Successfully merging this pull request may close these issues.
9 participants
@ti-srebot @ti-chi-bot @wshwsh12 @sre-bot @hawkingrei @XuHuaiyu @ichn-hu @VelocityLight @zhouqiang-cl