Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: Optimize code if else branch logic #28969

Merged
merged 14 commits into from
Nov 8, 2021
Merged

expression: Optimize code if else branch logic #28969

merged 14 commits into from
Nov 8, 2021

Conversation

Zh1Cheung
Copy link
Contributor

@Zh1Cheung Zh1Cheung commented Oct 20, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: #29518

Make the code more Readable

What is changed and how it works?

Reduce if else branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TszKitLo40
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Oct 20, 2021
@CLAassistant
Copy link

CLAassistant commented Oct 20, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 20, 2021
@ti-chi-bot
Copy link
Member

Welcome @Zh1Cheung!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@TszKitLo40
Copy link
Contributor

Please run gofmt for the file

TszKitLo40
TszKitLo40 suggested changes Oct 20, 2021
View reviewed changes
distsql/distsql.go Outdated Show resolved Hide resolved
@TszKitLo40
Copy link
Contributor

You also need to sign the Contributor License Agreement to pass the check.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 21, 2021
@Zh1Cheung Zh1Cheung changed the title expression: Return early for errors in the current file and Reduce if else branch expression: Optimize code if else branch logic Oct 21, 2021
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 21, 2021
@Zh1Cheung
Copy link
Contributor Author

Zh1Cheung commented Oct 21, 2021 •
edited
Loading

A similar error occurred of idc-jenkins-ci-tidb/check_dev_2：#24679

xhebox
xhebox reviewed Nov 5, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

server/server.go Outdated Show resolved Hide resolved
@Zh1Cheung
update the logic of cleanupStaleSocket() function
49190b3 
When it's occur error will return nil
TszKitLo40
TszKitLo40 approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@TszKitLo40 TszKitLo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2021
@Zh1Cheung Zh1Cheung mentioned this pull request Nov 5, 2021
Closed
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 8, 2021
@xhebox
Copy link
Contributor

xhebox commented Nov 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 58da6d7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2021
@ti-chi-bot
Copy link
Member

@Zh1Cheung: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit fdfba3e into pingcap:master Nov 8, 2021
@aytrack aytrack mentioned this pull request Nov 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@TszKitLo40 TszKitLo40 TszKitLo40 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zh1Cheung @ti-chi-bot @CLAassistant @TszKitLo40 @xhebox