Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: do not allow historical read in local temporary tables #27363

Merged
merged 8 commits into from
Aug 20, 2021

Conversation

sylzd
Copy link
Contributor

@sylzd sylzd commented Aug 19, 2021

What problem does this PR solve?

Issue Number: close #25938

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 19, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 19, 2021
@sylzd sylzd changed the title sql-infra: do not allow historical read in local temporary tables session: do not allow historical read in local temporary tables Aug 19, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Aug 19, 2021
@ti-chi-bot
Copy link
Member

@lcwangchao: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lcwangchao lcwangchao added the sig/sql-infra SIG: SQL Infra label Aug 19, 2021
@lcwangchao lcwangchao self-requested a review August 19, 2021 05:32
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 19, 2021
@sylzd
Copy link
Contributor Author

sylzd commented Aug 19, 2021

@lcwangchao @tiancaiamao It seems conflicts with TestCreateTemporaryTable, should we modify it?

	// Considering snapshot, local temporary table is always visible.
	tk.MustExec("set @@tidb_snapshot = '2016-01-01 15:04:05.999999'")
	tk.MustExec("select * from overlap")

@lcwangchao
Copy link
Collaborator

@lcwangchao @tiancaiamao It seems conflicts with TestCreateTemporaryTable, should we modify it?

	// Considering snapshot, local temporary table is always visible.
	tk.MustExec("set @@tidb_snapshot = '2016-01-01 15:04:05.999999'")
	tk.MustExec("select * from overlap")

I think we should remove this test.

@lcwangchao
Copy link
Collaborator

@sylzd Please modify the release note and set the content None

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. release-note-none Denotes a PR that doesn't merit a release note. and removed status/LGT1 Indicates that a PR has LGTM 1. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 19, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a6b44b7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 19, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 19, 2021
@sylzd
Copy link
Contributor Author

sylzd commented Aug 19, 2021

/run-check_dev_2

@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d9d7050

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 20, 2021
@sylzd
Copy link
Contributor Author

sylzd commented Aug 20, 2021

/run-check_dev_2

@sylzd
Copy link
Contributor Author

sylzd commented Aug 20, 2021

/run-tide

@ti-chi-bot ti-chi-bot merged commit 203b3b2 into pingcap:master Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do not allow historical read in local temporary tables
4 participants