expression: forbidden bind sql when subquery or union exists #27347

sylzd · 2021-08-18T11:32:31Z

What problem does this PR solve?

Issue Number: close #26377

Problem Summary:
When temporary table exits in subquery or be on of setOpr select list, binding sql will be return no error.

What is changed and how it works?

Proposal: xxx

What's Changed:
extractTableList Modified

How it Works:
extractTableList will work when subquery, setOpr exits.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2021-08-18T11:32:32Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

djshow832
lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

sylzd · 2021-08-18T14:23:25Z

/run-check_dev_2

lcwangchao · 2021-08-19T05:11:44Z

planner/core/preprocess.go

-		resNode = n.From.TableRefs
+		resNode = n
+	case *ast.SetOprStmt:
+		resNode = n
 	case *ast.DeleteStmt:
 		resNode = n.TableRefs.TableRefs
 	case *ast.UpdateStmt:


I think we should also check where expr in Delete/Update

Let's open a new issue about Delete/Update/Insert~

ok~ I have created a new issue #27422

thx a lot, I'm working on it.

bindinfo/bind_test.go

lcwangchao · 2021-08-19T05:37:48Z

planner/core/logical_plan_builder.go

 // extractTableList extracts all the TableNames from node.
 // If asName is true, extract AsName prior to OrigName.
 // Privilege check should use OrigName, while expression may use AsName.
+// TODO: extracting all tables by vistor model maybe a better way
 func extractTableList(node ast.ResultSetNode, input []*ast.TableName, asName bool) []*ast.TableName {


Maybe we can add a unit test for extractTableList ?

That's a big project. It seems most internal methods in logic_plan_builder.go do not have a UT, such as extractTableSourceAsNames , extractOnCondition .... and so on. I think it's probably tested by high level.

Adding a unit test is a better practice to prevent explosion of combinations. So even we have some integration tests we still need unit tests to ensure robustness of our code. But I will approve the pr because it is for forbidden bind sql when subquery or union exists . We may add a unit test for this method in another PR.

I agree to make a specific project to improve the test coverage about logic_plan_builder.go

tiancaiamao · 2021-08-20T06:45:05Z

/merge

ti-chi-bot · 2021-08-20T06:45:08Z

This pull request has been accepted and is ready to merge.

Commit hash: 7306096

sylzd · 2021-08-20T06:58:01Z

/run-check_dev_2

sylzd · 2021-08-20T07:08:46Z

/run-unit-test

zhouqiang-cl · 2021-08-20T08:13:22Z

/merge

ti-chi-bot · 2021-08-20T08:13:24Z

@zhouqiang-cl: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sylzd · 2021-08-20T08:44:32Z

/run-check_dev_2

ti-chi-bot · 2021-08-20T15:46:12Z

@sylzd: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sylzd · 2021-08-20T15:58:11Z

/run-unit-test

sylzd · 2021-08-20T17:28:36Z

/run-unit-test

sylzd · 2021-08-21T04:03:44Z

/run-unit-test

sylzd added 4 commits August 17, 2021 09:42

find bug pos, we should get table list from subquery recursive

061ac16

add visitor

81b9b49

done

1c36a1a

fix

b122f1f

ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 18, 2021

Merge branch 'master' into fix_26377_2

c825c54

github-actions bot added the sig/planner SIG: Planner label Aug 18, 2021

Merge branch 'master' into fix_26377_2

7ac1781

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2021

ichn-hu mentioned this pull request Aug 18, 2021

Welcome to contribute #20804

Closed

sylzd added 7 commits August 18, 2021 21:18

fix gosimple

56cce2e

Merge branch 'fix_26377_2' of github.com:sylzd/tidb into fix_26377_2

5966bc2

fix

02593fb

fix

78bb3b1

fix

5b4a7ae

simplify

151e2cd

happy lint

1e0142c

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 19, 2021

lcwangchao added the sig/sql-infra SIG: SQL Infra label Aug 19, 2021

lcwangchao reviewed Aug 19, 2021

View reviewed changes

sylzd mentioned this pull request Aug 19, 2021

expression: forbidden bind sql when subquery or set operation exists #27345

Closed

12 tasks

sylzd added 3 commits August 19, 2021 16:21

add local tests

c21f251

add some test cases

81ce253

add test cases

025253d

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 20, 2021

lcwangchao approved these changes Aug 20, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 20, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 20, 2021

Merge branch 'master' into fix_26377_2

5955ade

Merge branch 'master' into fix_26377_2

4c6de4d

Merge branch 'master' into fix_26377_2

f46cedd

sylzd and others added 8 commits August 20, 2021 17:26

Merge branch 'master' into fix_26377_2

fa28bb8

Merge branch 'master' into fix_26377_2

be844d5

Merge branch 'master' into fix_26377_2

0500429

Merge branch 'master' into fix_26377_2

9554423

Merge branch 'master' into fix_26377_2

3132c1a

Merge branch 'master' into fix_26377_2

89cf8d2

Merge branch 'master' into fix_26377_2

b0af726

Merge branch 'master' into fix_26377_2

bdb423c

ti-chi-bot merged commit 79aab25 into pingcap:master Aug 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

expression: forbidden bind sql when subquery or union exists #27347

expression: forbidden bind sql when subquery or union exists #27347

sylzd commented Aug 18, 2021 •

edited

Loading

ti-chi-bot commented Aug 18, 2021 •

edited

Loading

sylzd commented Aug 18, 2021

lcwangchao Aug 19, 2021

sylzd Aug 19, 2021

lcwangchao Aug 20, 2021

sylzd Aug 20, 2021 •

edited

Loading

lcwangchao Aug 19, 2021

sylzd Aug 19, 2021 •

edited

Loading

lcwangchao Aug 20, 2021 •

edited

Loading

sylzd Aug 20, 2021

tiancaiamao commented Aug 20, 2021

ti-chi-bot commented Aug 20, 2021

sylzd commented Aug 20, 2021

sylzd commented Aug 20, 2021

zhouqiang-cl commented Aug 20, 2021

ti-chi-bot commented Aug 20, 2021

sylzd commented Aug 20, 2021

ti-chi-bot commented Aug 20, 2021

sylzd commented Aug 20, 2021

sylzd commented Aug 20, 2021

sylzd commented Aug 21, 2021

expression: forbidden bind sql when subquery or union exists #27347

expression: forbidden bind sql when subquery or union exists #27347

Conversation

sylzd commented Aug 18, 2021 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Aug 18, 2021 • edited Loading

sylzd commented Aug 18, 2021

lcwangchao Aug 19, 2021

Choose a reason for hiding this comment

sylzd Aug 19, 2021

Choose a reason for hiding this comment

lcwangchao Aug 20, 2021

Choose a reason for hiding this comment

sylzd Aug 20, 2021 • edited Loading

Choose a reason for hiding this comment

lcwangchao Aug 19, 2021

Choose a reason for hiding this comment

sylzd Aug 19, 2021 • edited Loading

Choose a reason for hiding this comment

lcwangchao Aug 20, 2021 • edited Loading

Choose a reason for hiding this comment

sylzd Aug 20, 2021

Choose a reason for hiding this comment

tiancaiamao commented Aug 20, 2021

ti-chi-bot commented Aug 20, 2021

sylzd commented Aug 20, 2021

sylzd commented Aug 20, 2021

zhouqiang-cl commented Aug 20, 2021

ti-chi-bot commented Aug 20, 2021

sylzd commented Aug 20, 2021

ti-chi-bot commented Aug 20, 2021

sylzd commented Aug 20, 2021

sylzd commented Aug 20, 2021

sylzd commented Aug 21, 2021

sylzd commented Aug 18, 2021 •

edited

Loading

ti-chi-bot commented Aug 18, 2021 •

edited

Loading

sylzd Aug 20, 2021 •

edited

Loading

sylzd Aug 19, 2021 •

edited

Loading

lcwangchao Aug 20, 2021 •

edited

Loading