-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: Fix wrong charset and collation for case when function #26663
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
/run-integration-tests |
/run-integration-tests |
/run-integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5a4bf46
|
/rebuild |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-4.0 in PR #26671 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.0 in PR #26672 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.1 in PR #26673 |
What problem does this PR solve?
Issue Number: close #26662
Problem Summary:
Wrong collation will lead expression.ColumnSubstitute can't generate newFilter for LogicalProjection in ppdSolver.
Because there is a collation check in ColumnSubstitute.
tidb/expression/util.go
Lines 234 to 245 in b073d6b
What is changed and how it works?
What's Changed:
Use function DeriveCollationFromExprs to get collation for caseWhen function
How it Works:
Check List
Tests
Side effects
Documentation
Release note