Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: support showing label rule through information schema table #26637

Merged
merged 6 commits into from
Aug 9, 2021

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jul 27, 2021

What problem does this PR solve?

Closes #26694. It can be reviewed after #26630 is merged.

What is changed and how it works?

This PR is going to provide a way to show the label rules through SQL.

mysql> create table t1 (c int);
Query OK, 0 rows affected (0.08 sec)

mysql> alter table t1 attributes="attr";
Query OK, 0 rows affected (0.07 sec)

mysql> select * from information_schema.region_label;
+----------------+-----------+--------------+--------------------------------------+--------------------------------------+
| RULE_ID        | RULE_TYPE | REGION_LABEL | START_KEY                            | END_KEY                              |
+----------------+-----------+--------------+--------------------------------------+--------------------------------------+
| schema/test/t1 | key-range | "attr"       | 7480000000000000ff355f720000000000fa | 7480000000000000ff365f720000000000fa |
+----------------+-----------+--------------+--------------------------------------+--------------------------------------+

What's Changed:

  1. add a new memory table named region_label in information_schema to show the label rules
  2. add GetAllLabelRules to retrieve all rules

Check List

Tests

  • Unit test

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 27, 2021
@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Jul 27, 2021
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 30, 2021
@rleungx rleungx force-pushed the region-label-info branch from 79c9269 to f7e8219 Compare July 30, 2021 09:55
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 30, 2021
@rleungx
Copy link
Member Author

rleungx commented Jul 30, 2021

/cc @xhebox @Yisaer @JmPotato

@ti-chi-bot ti-chi-bot requested review from xhebox and Yisaer July 30, 2021 09:59
@ti-chi-bot
Copy link
Member

@rleungx: GitHub didn't allow me to request PR reviews from the following users: JmPotato.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @xhebox @Yisaer @JmPotato

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xhebox
Copy link
Contributor

xhebox commented Aug 2, 2021

Plz reping me after the other PR merged.

Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the region_label table is not proper for tidb while it is more suitable to display by PD. As region label is designed for table, I think it should be more proper to display label in infoschema.table

@xhebox
Copy link
Contributor

xhebox commented Aug 5, 2021

I think the region_label table is not proper for tidb while it is more suitable to display by PD. As region label is designed for table, I think it should be more proper to display label in infoschema.table

@rleungx Do we have an agreement on the behavior now?

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2021
@rleungx
Copy link
Member Author

rleungx commented Aug 5, 2021

PTAL @Yisaer

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 5, 2021
@rleungx rleungx force-pushed the region-label-info branch from f7e8219 to 77bfbc7 Compare August 6, 2021 05:38
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 9, 2021
@xhebox
Copy link
Contributor

xhebox commented Aug 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 77bfbc7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 9, 2021
@ti-chi-bot
Copy link
Member

@rleungx: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support showing label rule through information schema table
4 participants