-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: support showing label rule through information schema table #26637
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
79c9269
to
f7e8219
Compare
@rleungx: GitHub didn't allow me to request PR reviews from the following users: JmPotato. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. |
Plz reping me after the other PR merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the region_label
table is not proper for tidb while it is more suitable to display by PD. As region label
is designed for table, I think it should be more proper to display label in infoschema.table
@rleungx Do we have an agreement on the behavior now? |
PTAL @Yisaer |
Signed-off-by: Ryan Leung <[email protected]>
f7e8219
to
77bfbc7
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 77bfbc7
|
@rleungx: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Closes #26694. It can be reviewed after #26630 is merged.
What is changed and how it works?
This PR is going to provide a way to show the label rules through SQL.
What's Changed:
GetAllLabelRules
to retrieve all rulesCheck List
Tests
Documentation
Release note