Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression, executor: fix type infer for greatest/leastest(datetime) #26533

Merged
merged 5 commits into from
Jul 26, 2021
Merged

expression, executor: fix type infer for greatest/leastest(datetime) #26533

merged 5 commits into from
Jul 26, 2021

Conversation

XuHuaiyu
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #26532

Problem Summary:

What is changed and how it works?

What's Changed:
Make the flen of greatest/leatest(datetime) correct

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

  • Fix the issue that greatest(datetime) union null returns empty string

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 25, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Jul 25, 2021
@zhouqiang-cl
Copy link
Contributor

/rebuild

@XuHuaiyu
Copy link
Contributor Author

/run-integration-tests

@ichn-hu ichn-hu mentioned this pull request Jul 26, 2021
Closed
@wshwsh12 wshwsh12 self-requested a review July 26, 2021 07:50
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 26, 2021
@XuHuaiyu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4070f37

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 26, 2021
@ti-chi-bot ti-chi-bot merged commit dd2fadb into pingcap:master Jul 26, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2021
@XuHuaiyu @ti-srebot
cherry pick pingcap#26533 to release-4.0
1307803 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jul 26, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #26564

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2021
@XuHuaiyu @ti-srebot
cherry pick pingcap#26533 to release-5.0
f256d09 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jul 26, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #26565

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2021
@XuHuaiyu @ti-srebot
cherry pick pingcap#26533 to release-5.1
12ca879 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jul 26, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #26566

ti-chi-bot pushed a commit that referenced this pull request Aug 12, 2021
@ti-srebot
expression, executor: fix type infer for greatest/leastest(datetime) (#…
6b70fe8 
…26533) (#26565)
ti-chi-bot pushed a commit that referenced this pull request Sep 13, 2021
@ti-srebot
expression, executor: fix type infer for greatest/leastest(datetime) (#…
2383ccc 
…26533) (#26564)
ti-chi-bot pushed a commit that referenced this pull request Sep 16, 2021
@ti-srebot
expression, executor: fix type infer for greatest/leastest(datetime) (#…
8f91145 
…26533) (#26566)
@guo-shaoge guo-shaoge mentioned this pull request Mar 1, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unexpected result of union
6 participants
@XuHuaiyu @zhouqiang-cl @ti-chi-bot @ti-srebot @guo-shaoge @wshwsh12