Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: select distinct should bypass batchget (#25477) #25534

Merged
merged 5 commits into from
Jun 18, 2021
Merged

planner: select distinct should bypass batchget (#25477) #25534

merged 5 commits into from
Jun 18, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 17, 2021 •
edited
Loading

cherry-pick #25477 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25534

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/25534:release-5.1-ba77a2f58f9d

What problem does this PR solve?

Issue Number: close #25320

Problem Summary:

  • Query with distinct gets wrong result

What is changed and how it works?

What's Changed:

  • func tryWhereIn2BatchPointGet

How it Works:

  • do not generate batchget plan if distinct is in the statement.

Check List

Tests

  • Unit test

Side effects

  • N/A

Release note

  • planner: select distinct should bypass batchget

@ti-srebot ti-srebot requested review from a team as code owners June 17, 2021 12:40
@ti-srebot ti-srebot requested review from wshwsh12 and winoros and removed request for a team June 17, 2021 12:40
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.1-cherry-pick labels Jun 17, 2021
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2021
Merged
@ti-srebot
Copy link
Contributor Author

@qw4990 you're already a collaborator in bot's repo.

@xiongjiwei xiongjiwei removed their request for review June 17, 2021 13:24
@zhouqiang-cl zhouqiang-cl added backport-5.1.0 cherry-pick-approved Cherry pick PR approved by release team. labels Jun 18, 2021
@time-and-fate
Copy link
Member

/run-check_dev

@time-and-fate
Copy link
Member

/run-unit-test

1 similar comment
@time-and-fate
Copy link
Member

/run-unit-test

@ti-chi-bot
Copy link
Member

@time-and-fate: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@time-and-fate
Copy link
Member

/sig planner

@ti-chi-bot ti-chi-bot added the sig/planner SIG: Planner label Jun 18, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 18, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 18, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2c68784

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@wshwsh12 wshwsh12 removed their request for review June 18, 2021 06:52
@wjhuang2016 wjhuang2016 removed their request for review June 18, 2021 07:59
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3dbbe24

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 18, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@zhouqiang-cl
Copy link
Contributor

/merge

@zhouqiang-cl
Copy link
Contributor

/run-check_dev

@zhouqiang-cl zhouqiang-cl merged commit 727fd95 into pingcap:release-5.1 Jun 18, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees

@qw4990 qw4990

Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/execution SIG execution sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.1-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @time-and-fate @ti-chi-bot @zhouqiang-cl @qw4990 @zhuo-zhi