Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix wrong aggregate pruning for some cases (#25289) #25471

Merged
merged 2 commits into from
Jun 30, 2021
Merged

planner: fix wrong aggregate pruning for some cases (#25289) #25471

merged 2 commits into from
Jun 30, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 16, 2021 •
edited
Loading

cherry-pick #25289 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25471

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/25471:release-5.0-cea06b3d4961

Signed-off-by: lzmhhh123 [email protected]

What problem does this PR solve?

Issue Number: close #25202

What is changed and how it works?

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • fix wrong aggregate pruning for some cases

@ti-srebot ti-srebot requested a review from a team as a code owner June 16, 2021 06:13
@ti-srebot ti-srebot requested review from lzmhhh123 and removed request for a team June 16, 2021 06:13
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Jun 16, 2021
Merged
@ti-srebot ti-srebot added sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.0-cherry-pick type/bugfix This PR fixes a bug. labels Jun 16, 2021
@ti-srebot ti-srebot added this to the v5.0.2 milestone Jun 16, 2021
@ti-chi-bot ti-chi-bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 16, 2021
@ti-srebot
Copy link
Contributor Author

@lzmhhh123 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 16, 2021
@wshwsh12 wshwsh12 removed their request for review June 16, 2021 08:00
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 16, 2021
@zhouqiang-cl zhouqiang-cl removed the cherry-pick-approved Cherry pick PR approved by release team. label Jun 16, 2021
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 16, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2021
@lzmhhh123 lzmhhh123 removed their request for review June 28, 2021 02:40
@zhouqiang-cl zhouqiang-cl added backport-5.0.3 cherry-pick-approved Cherry pick PR approved by release team. labels Jun 29, 2021
@lzmhhh123 lzmhhh123 force-pushed the release-5.0-cea06b3d4961 branch from 0b309c5 to 65e8eb1 Compare June 30, 2021 03:23
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 30, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • eurekaka
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 30, 2021
@eurekaka
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 65e8eb1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 30, 2021
@lzmhhh123
Copy link
Contributor

/merge

@zhouqiang-cl
Copy link
Contributor

/run-unit-tests

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zhouqiang-cl
Copy link
Contributor

/run-unit-tests

@ti-chi-bot ti-chi-bot merged commit 6312cee into pingcap:release-5.0 Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@eurekaka eurekaka eurekaka approved these changes

@rebelice rebelice Awaiting requested review from rebelice

Assignees

@lzmhhh123 lzmhhh123

Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.0-cherry-pick
Projects
None yet
Milestone
v5.0.2
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @ti-chi-bot @eurekaka @lzmhhh123 @zhouqiang-cl @winoros