Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: add admin_checksum_table compatibility for temporary table #24867

Merged
merged 10 commits into from
May 31, 2021
Merged

ddl: add admin_checksum_table compatibility for temporary table #24867

merged 10 commits into from
May 31, 2021

Conversation

Howie59
Copy link
Contributor

@Howie59 Howie59 commented May 24, 2021

What problem does this PR solve?

Issue Number: see #24168

What is changed and how it works?

Proposal: temporary table

What's Changed: add admin checksum table compatibility for temporary table

Check List

Tests

  • Unit test

Release note

  • No release note

@Howie59 Howie59 requested review from a team as code owners May 24, 2021 14:24
@Howie59 Howie59 requested review from XuHuaiyu and removed request for a team May 24, 2021 14:24
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 24, 2021
@github-actions github-actions bot added the sig/execution SIG execution label May 24, 2021
@djshow832 djshow832 mentioned this pull request May 25, 2021
Closed
89 tasks
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 25, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label May 25, 2021
tiancaiamao
tiancaiamao reviewed May 28, 2021
View reviewed changes
executor/admin_test.go Outdated
Comment on lines 100 to 101
fmt.Println(core.ErrOptOnTemporaryTable.GenWithStackByArgs("admin checksum table"))
fmt.Println(err.Error())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove debug log please ...

planner/core/preprocess.go Outdated
if stmt.Tp == ast.AdminChecksumTable {
p.err = ErrOptOnTemporaryTable.GenWithStackByArgs("admin checksum table")
} else {
p.err = infoschema.ErrAdminCheckTable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
p.err = infoschema.ErrAdminCheckTable
p.err = ErrOptOnTemporaryTable.GenWithStackByArgs("admin table")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ErrAdminCheckTable is another kind of error, it means the admin check table fails because of the table data corruption.
Here we should report something like "unsupported operation", although the operation fails and returns error, the reason is different.

@Howie59
modify err
6ffd9e2 
Signed-off-by: lihaowei <[email protected]>
@tiancaiamao
Copy link
Contributor

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2021
@djshow832
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 31, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6ffd9e2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2021
@djshow832 djshow832 removed request for a team and XuHuaiyu May 31, 2021 06:54
@djshow832
Copy link
Contributor

/run-all-tests

@djshow832
Copy link
Contributor

UT failed due to TestPrepareCacheForPartition. Reruning...

@djshow832
Copy link
Contributor

/run-unit-test

@ti-chi-bot
Copy link
Member

@Howie59: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@djshow832
Copy link
Contributor

UT failed due to TestAnalyzeGlobalStatsWithOpts2. Reruning...

@djshow832
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 11019d6 into pingcap:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao left review comments

@djshow832 djshow832 djshow832 approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Howie59 @tiancaiamao @djshow832 @ti-chi-bot