-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: include schema name when checking duplicate table aliases #24663
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/run-all-tests |
/run-e2e-test |
integration-common-test |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a bad case:
select * from db1.t as t1, (select * from t) as t1;
This is valid on MySQL 8.0.25 but invalid on this PR.
@eurekaka: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Well, the behavior difference of MySQL for these 2 queries is pretty confusing.
|
Close this PR until we find another solution to cover all MySQL behaviors. |
tested in MySQL 8.0.27, seems it's valid now mysql> select version();
+--------------+
| version() |
+--------------+
| 8.0.27-debug |
+--------------+
1 row in set (0.00 sec)
mysql> select * from db1.t1 as t1, t1 as t1;
Empty set (0.00 sec) |
What problem does this PR solve?
Issue Number: close #24563
close #24550
Problem Summary:
Incompatible behaviors regarding duplicate table alias check with MySQL.
What is changed and how it works?
What's Changed:
Include schema name when checking duplicate table aliases.
Related changes
N/A
Check List
Tests
Side effects
N/A
Release note