Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix float64 overflow check in plus/minus real function #24179

Merged
merged 10 commits into from
Jun 24, 2021
Merged

expression: fix float64 overflow check in plus/minus real function #24179

merged 10 commits into from
Jun 24, 2021

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Apr 21, 2021 •
edited
Loading

Need port to TiKV

What problem does this PR solve?

Issue Number: close #23897

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:
We should keep the overflow check logic same with mysql.

How it Works:

Related changes

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Keep the overflow check logic same with mysql

@wshwsh12 wshwsh12 requested a review from a team as a code owner April 21, 2021 03:27
@wshwsh12 wshwsh12 requested review from XuHuaiyu and removed request for a team April 21, 2021 03:27
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 21, 2021
@wshwsh12 wshwsh12 changed the title expression: fix float64 overflow check expression: fix float64 overflow check in plus/minus real function Apr 21, 2021
@XuHuaiyu XuHuaiyu added the type/bugfix This PR fixes a bug. label Apr 21, 2021
@ichn-hu ichn-hu mentioned this pull request Apr 21, 2021
Closed
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2021
XuHuaiyu
XuHuaiyu reviewed Apr 27, 2021
View reviewed changes
tools/check/go.mod Outdated Show resolved Hide resolved
@wshwsh12 wshwsh12 requested a review from XuHuaiyu April 28, 2021 03:28
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2021
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 6, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2021
@XuHuaiyu
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 10, 2021
@wshwsh12
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2021
@wshwsh12
Copy link
Contributor Author

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2021
@wshwsh12
Copy link
Contributor Author

/run-all-tests

@wshwsh12 wshwsh12 mentioned this pull request Jun 10, 2021
Merged
@guo-shaoge guo-shaoge removed the request for review from XuHuaiyu June 11, 2021 02:39
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2021
@wshwsh12
Copy link
Contributor Author

/run-common-test tikv=pr/10337
/run-integration-common-test tikv=pr/10337
/run-integration-copr-test tikv=pr/10337

@wshwsh12
Copy link
Contributor Author

/run-integration-ddl-test tikv=pr/10337
/run-integration-compatibility-test tikv=pr/10337
/run-integration-br-test tikv=pr/10337

@wshwsh12
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7a6a757

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 24, 2021
@ti-chi-bot ti-chi-bot merged commit 88b587c into pingcap:master Jun 24, 2021
jiajunhuang pushed a commit to jiajunhuang/tidb that referenced this pull request Jun 28, 2021
@wshwsh12 @jiajunhuang
expression: fix float64 overflow check in plus/minus real function (p…
47d7607 
…ingcap#24179)
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 29, 2021
@wshwsh12 @ti-srebot
cherry pick pingcap#24179 to release-5.0
4540c9b 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jul 29, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #26724

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 29, 2021
@wshwsh12 @ti-srebot
cherry pick pingcap#24179 to release-5.1
f91488e 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jul 29, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #26725

This was referenced Sep 2, 2021
Merged
Merged
ti-chi-bot pushed a commit that referenced this pull request Sep 3, 2021
@ti-srebot
expression: fix float64 overflow check in plus/minus real function (#…
a58a482 
…24179) (#26724)
ti-chi-bot pushed a commit that referenced this pull request Sep 16, 2021
@ti-srebot
expression: fix float64 overflow check in plus/minus real function (#…
0296d13 
…24179) (#26725)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tidb panic: indexHashJoinInnerWorker.doJoinUnordered failed while execute with prepare
6 participants
@wshwsh12 @XuHuaiyu @ti-chi-bot @ti-srebot @lzmhhh123 @jebter