Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: fix audit plugin will cause tidb panic #23803

Merged
merged 12 commits into from
Apr 2, 2021
4 changes: 4 additions & 0 deletions server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,10 @@ func (s *Server) onConn(conn *clientConn) {
conn.Run(ctx)

err = plugin.ForeachPlugin(plugin.Audit, func(p *plugin.Plugin) error {
// Audit plugin may be disabled before a conn is created, leading no connectionInfo in sessionVars.
if sessionVars.ConnectionInfo == nil {
conn.ctx.GetSessionVars().ConnectionInfo = conn.connectInfo()
}
authPlugin := plugin.DeclareAuditManifest(p.Manifest)
if authPlugin.OnConnectionEvent != nil {
sessionVars.ConnectionInfo.Duration = float64(time.Since(connectedTime)) / float64(time.Millisecond)
Expand Down