Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: check schema stale for plan cache when forUpdateRead (#22381) #23435

Merged
merged 6 commits into from
Mar 26, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 19, 2021

cherry-pick #22381 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23435

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/23435:release-5.0-92b1b8e0e959

What problem does this PR solve?

Issue Number: #21498 will also affected plan cache.

Problem Summary:

What is changed and how it works?

What's Changed: when the plan is using forUpdateRead, we need to use the latest schema to check if plan is valid.

How it Works:

Update schema version when required.

Related changes

  • Need to cherry-pick to the release-4.0

Check List

Tests

  • Unit test

Release note

  • Fix a bug that plan cache may use stable schema version.

@ti-srebot ti-srebot requested review from a team as code owners March 19, 2021 09:29
@ti-srebot ti-srebot requested review from wshwsh12 and XuHuaiyu and removed request for a team March 19, 2021 09:29
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.0-cherry-pick type/bugfix This PR fixes a bug. labels Mar 19, 2021
@ti-srebot ti-srebot requested review from lysu and winoros March 19, 2021 09:29
@ti-srebot ti-srebot added this to the v5.0.0 ga milestone Mar 19, 2021
@ti-srebot
Copy link
Contributor Author

@you06 you're already a collaborator in bot's repo.

@eurekaka
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 26, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • eurekaka
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 26, 2021
@zz-jason
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ce8ea9b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 26, 2021
@zz-jason
Copy link
Member

/merge

@zz-jason
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit c129aba into pingcap:release-5.0 Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants