*: Add the metric about the SQL with TiFlash Success

[jyz0309]

Signed-off-by: jyz0309 [email protected]

What problem does this PR solve?

Problem Summary:
This pull request is for the TiDB SLO，to add the metric about the SQL with TiFlash

What is changed and how it works?

What's Changed:
Add two metrics for coprocessor send to promethus.

TiFlashExecuteCounter: The total num of SQL request send TiFlash.
TiFlashExecuteErrorCounter: The total num of SQL request error send TiFlash.

Related changes

• Need to cherry-pick to the release branch

Check List

Tests

• Unit test
• Manual test (add detailed scripts or steps below)

Side effects

• Performance regression
  • Consumes more CPU

Release note

• Add the metric about the SQL with TiFlash Success

[crazycs520]

Suggested change

	TiFlashExecuteErrorCounter = prometheus.NewCounter(
	prometheus.CounterOpts{
	Namespace: namespace,
	Subsystem: subsystem,
	Name: "tiflash_execute_error_total",
	Help: "Counter of TiFlash execute errors.",
	})
	TiFlashExecuteSuccCounter = prometheus.NewCounter(
	prometheus.CounterOpts{
	Namespace: namespace,
	Subsystem: subsystem,
	Name: "tiflash_execute_total",
	Help: "Counter of TiFlash execute successfully.",
	})
	TiFlashExecuteErrorCounter = prometheus.NewCounterVec(
	prometheus.CounterOpts{
	Namespace: namespace,
	Subsystem: subsystem,
	Name: "tiflash_requests_total",
	Help: "Counter of TiFlash requests.",
	}, []string{LblResult})

[crazycs520]

Use 1 metric counter is much easer to calculate the Number of “Failure query” / total queries

[crazycs520]

Oh, wait, The original demand is calculate the ** failure query**, not the failure tiflash cop request.

so the metric maybe rename to following is better.

	TiFlashQueryTotalCounter = prometheus.NewCounterVec(
		prometheus.CounterOpts{
			Namespace: "tidb",
			Subsystem: "server",
			Name:      "tiflash_query_total",
			Help:      "Counter of TiFlash queries.",
		}, []string{LblResult})

And the metrics should put in metrics/server.go file.

[breezewish]

I suspect whether the "total queries" are counted correctly if we use an existing metrics. For example, does it count DDL? Does it count prepared statements? etc. I think @jyz0309 should take a look about this first before making this change, make sure that "total queries" to be replaced is exactly the same as the counter we added here.

[crazycs520]

LGTM

[ti-chi-bot]

@crazycs520: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• breeswish
• crazycs520

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

[crazycs520]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: b7a6b33

[ti-srebot]

cherry pick to release-4.0 in PR #23517

[ti-srebot]

cherry pick to release-5.0 in PR #23956