-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: hide the config global-kill
and session var tidb_enable_index_merge_join
(#23395)
#23407
*: hide the config global-kill
and session var tidb_enable_index_merge_join
(#23395)
#23407
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
@XuHuaiyu you're already a collaborator in bot's repo. |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 57e7df8
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
The unit-test failed because of the following case, it has nothing to do with this commit 1-03-18T11:45:45.598Z] FAIL: simple_test.go:606: testSuite3.TestDropPartitionStats
[2021-03-18T11:45:45.598Z]
[2021-03-18T11:45:45.598Z] simple_test.go:631:
[2021-03-18T11:45:45.598Z] tk.MustExec("analyze table t")
[2021-03-18T11:45:45.598Z] /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:217:
[2021-03-18T11:45:45.598Z] tk.c.Assert(err, check.IsNil, check.Commentf("sql:%s, %v, error stack %v", sql, args, errors.ErrorStack(err)))
[2021-03-18T11:45:45.598Z] ... value *errors.withStack = [stats]: some partition level statistics are not in statistics version 2, please set tidb_analyze_version to 2 and analyze the this table ("[stats]: some partition level statistics are not in statistics version 2, please set tidb_analyze_version to 2 and analyze the this table")
[2021-03-18T11:45:45.598Z] ... sql:analyze table t, [], error stack [stats]: some partition level statistics are not in statistics version 2, please set tidb_analyze_version to 2 and analyze the this table |
cherry-pick #23395 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/23407
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Problem Summary:
What is changed and how it works?
What's Changed:
The features
global-kill
andindex merge join
are experimental features, thus we need to hide the config and session variables.How it Works:
Related changes
pingcap/docs
/pingcap/docs-cn
:hide the config global-kill docs-cn#5770
Check List
Tests
Side effects
N/A
Release note