-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix get var expr when session var is hex literal (#23241) #23372
executor: fix get var expr when session var is hex literal (#23241) #23372
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
@guo-shaoge you're already a collaborator in bot's repo. |
@lzmhhh123 @XuHuaiyu PTAL |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/label cherry-pick-approved |
@zhouqiang-cl: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 265313e
|
/run-unit-tests |
cherry-pick #23241 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/23372
After apply modifications, you can push your change to this PR via:
Signed-off-by: guo-shaoge [email protected]
What problem does this PR solve?
Issue Number: close #22949
Problem Summary:
GetVar expr(@sess_var) return string type when session_var is hex literal(eg: @sess_var = 0x3135), which is converted to '15'. Actually we should return BinaryLiteral type, but we dont have BinaryLiteral eval type.
What is changed and how it works?
What's Changed:
Related changes
Check List
Tests
Integration test: expression.TestGetVarExprWithHexLiteral()
Side effects: no
Release note