Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: metrics slow query is divided into internal and general #22350

Merged
merged 10 commits into from
Jan 15, 2021
Merged

executor: metrics slow query is divided into internal and general #22350

merged 10 commits into from
Jan 15, 2021

Conversation

7yyo
Copy link
Contributor

@7yyo 7yyo commented Jan 11, 2021 •
edited
Loading

What problem does this PR solve?

Currently slow query metrics contains internal SQL,
These internal SQL may affect customers and DBA analysis problems, so add label to distinguish internal and general.

image

What is changed and how it works?

What's Changed:

Slow query is divided into internal and general labels

How it Works:

Slow query is divided into internal and general labels

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

  • Metrics slow query is divided into internal and general

@7yyo 7yyo requested a review from a team as a code owner January 11, 2021 11:35
@7yyo 7yyo requested review from wshwsh12 and removed request for a team January 11, 2021 11:35
@sre-bot
Copy link
Contributor

sre-bot commented Jan 11, 2021

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@github-actions github-actions bot added the sig/execution SIG execution label Jan 11, 2021
@7yyo
Copy link
Contributor Author

7yyo commented Jan 11, 2021

/rebuild

@7yyo 7yyo changed the title executor: Metrics slow log without internal sql executor: Metrics slow query without internal sql Jan 11, 2021
@7yyo
Copy link
Contributor Author

7yyo commented Jan 11, 2021

@jackysp PTAL

jackysp
jackysp reviewed Jan 11, 2021
View reviewed changes
.github/FUNDING.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jan 14, 2021
@7yyo 7yyo changed the title executor: Metrics slow query without internal sql executor: Metrics slow query is divided into internal and general Jan 14, 2021
7yyo
7yyo commented Jan 14, 2021
View reviewed changes
Copy link
Contributor Author

@7yyo 7yyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

.github/FUNDING.yml Outdated Show resolved Hide resolved
executor/adapter.go Show resolved Hide resolved
@jackysp jackysp changed the title executor: Metrics slow query is divided into internal and general executor: metrics slow query is divided into internal and general Jan 15, 2021
@jackysp
Copy link
Member

jackysp commented Jan 15, 2021

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Jan 15, 2021

Visit the grafana server at: http://172.16.5.5:30401, it will last for 5 hours

@7yyo
Copy link
Contributor Author

7yyo commented Jan 15, 2021

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Jan 15, 2021

Visit the grafana server at: http://172.16.5.5:31980, it will last for 5 hours

jackysp
jackysp reviewed Jan 15, 2021
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 15, 2021
lysu
lysu reviewed Jan 15, 2021
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 15, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 15, 2021
@lysu
Copy link
Contributor

lysu commented Jan 15, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 15, 2021
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 42edd7a into pingcap:master Jan 15, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 15, 2021
@7yyo @ti-srebot
cherry pick pingcap#22350 to release-4.0
8840d64 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jan 15, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #22405

@ti-srebot ti-srebot mentioned this pull request Jan 15, 2021
Closed
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 15, 2021
@7yyo @ti-srebot
cherry pick pingcap#22350 to release-5.0-rc
8380837 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0-rc in PR #22406

@7yyo 7yyo deleted the metricsSlowLogWithoutInternalSQL branch January 15, 2021 13:56
ti-srebot added a commit that referenced this pull request Jan 20, 2021
@ti-srebot
executor: metrics slow query is divided into internal and general (#2…
3471f69 
…2350) (#22405)

Signed-off-by: ti-srebot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@jackysp jackysp jackysp left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@7yyo @sre-bot @jackysp @lysu @ti-srebot