Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: forbid SFU on view #22146

Closed
wants to merge 5 commits into from
Closed

executor: forbid SFU on view #22146

wants to merge 5 commits into from

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Jan 4, 2021 •
edited
Loading

Signed-off-by: lysu [email protected]

What problem does this PR solve?

Issue Number: close #21335

Problem Summary:

just as issue said

What is changed and how it works?

What's Changed, How it Works:

check SFU on view in ast -> plan stage

Related changes

  • Need to cherry-pick to the release branch 5.1

Check List

Tests

  • Unit test

Side effects

  • n/a

Release note

  • forbid SELECT FOR UPDATE on view

This change is Reviewable

@lysu lysu requested review from a team as code owners January 4, 2021 04:34
@lysu lysu requested review from SunRunAway, qw4990 and you06 and removed request for a team and SunRunAway January 4, 2021 04:34
@you06
Copy link
Contributor

you06 commented Jan 4, 2021 •
edited
Loading

select * from t where c1 in (select c1 from v) for update should be executed but got fail.

@ichn-hu ichn-hu mentioned this pull request Jan 4, 2021
Closed
@lysu
Copy link
Contributor Author

lysu commented Jan 4, 2021

select * from t where c1 in (select c1 from v) for update should be executed but got fail.

good catch, and added more test case, ptal if free~

you06
you06 reviewed Jan 5, 2021
View reviewed changes
Copy link
Contributor

@you06 you06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@you06, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: execution(slack).

tangenta
tangenta approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 5, 2021
@zz-jason
Copy link
Member

zz-jason commented Feb 9, 2021

@lysu It's a major bug-fix, no need to cherry-pick to 5.o-rc.

@ti-chi-bot
Copy link
Member

@lysu: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 21, 2021
@qw4990 qw4990 removed their request for review June 23, 2021 03:40
@qw4990
Copy link
Contributor

qw4990 commented Jun 23, 2021

Can we merge it? @lysu

@zz-jason
Copy link
Member

zz-jason commented Apr 6, 2022

I'm going to close this PR since it hasn't been updated for a long time. Feel free to reopen it once you wish to advance this PR in the future.

@zz-jason zz-jason closed this Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@you06 you06 you06 left review comments

@winoros winoros winoros approved these changes

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

select for update doesn't seem to work on views in some cases
8 participants
@lysu @you06 @ti-srebot @zz-jason @ti-chi-bot @qw4990 @winoros @tangenta