planner: fix the fail when we compare multi fields in the subquery #21699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @lzmhhh123 |
|
/cc @winoros |
|
/run-all-tests |
|
/label sig/planner, type/bug-fix |
Closed
XuHuaiyu
reviewed
Dec 15, 2020
| @@ -538,6 +539,7 @@ func (er *expressionRewriter) handleCompareSubquery(ctx context.Context, v *ast. | |||
| } else if v.Op == opcode.NE { | |||
| if v.All { | |||
| // `a != all(subq)` will be rewriten as `a not in (subq)`. | |||
| er.asScalar = true | |||
There was a problem hiding this comment.
The test case does not cover this?
|
/run-all-tests |
|
@XuHuaiyu Update.PTAL! |
ti-srebot
approved these changes
Dec 15, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Dec 15, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #21808 |
qw4990
pushed a commit
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #13551 close #21674
Problem Summary:
When we use
(SELECT c1, c2 FROM t2 LIMIT 1) = ANY (SELECT c1, c2 FROM t1)in thewherestatement, theexpressionRewrite.ctxStackwill store the result value ofSELECT c1, c2 FROM t2 LIMIT 1. So in issue#21674, when the value of c1 is zero, the plan will be convert totableDual.What is changed and how it works?
So, we should set
expressionRewrite.asScalar = truelikehandleInSubqueryfunction. It will use the parent expression's last column from the schema to represents whether the condition is matched(https://github.com/pingcap/tidb/blob/master/planner/core/expression_rewriter.go#L558-L561).Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note