Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner, sessionctx : Add 'last_plan_from_binding' to help know whether sql's plan is matched with the hints in the binding (#18017) #21430

Merged
merged 6 commits into from
Mar 12, 2021
Merged

planner, sessionctx : Add 'last_plan_from_binding' to help know whether sql's plan is matched with the hints in the binding (#18017) #21430

merged 6 commits into from
Mar 12, 2021

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #18017 to release-4.0

What problem does this PR solve?

Issue Number: close #16425

Problem Summary:
Add last_plan_from_binding to help know whether sql's plan is matched with the hints in the binding

What is changed and how it works?

What's Changed:

  • add a session scope system variable last_plan_from_binding to help decide whether the plan cache got hit.
  • display the last_plan_from_binding in slow log and statement summary table

Check List

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn

  • Unit test

  • Integration test

Release note

  • Add 'last_plan_from_binding' to help know whether sql's plan is matched with the hints in the binding

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Dec 2, 2020
Merged
@ti-srebot ti-srebot added this to the 4.0.0 milestone Dec 2, 2020
@ti-srebot
Copy link
Contributor Author

@Reminiscent you're already a collaborator in bot's repo.

@Reminiscent Reminiscent mentioned this pull request Dec 2, 2020
Closed
9 tasks
@Reminiscent
Copy link
Contributor

@eurekaka @zz-jason PTAL. Thanks!

eurekaka
eurekaka reviewed Dec 2, 2020
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 2, 2020
@eurekaka
Copy link
Contributor

eurekaka commented Dec 2, 2020

/run-all-tests

qw4990
qw4990 approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 2, 2020
@Reminiscent
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @Reminiscent, this branch's release version is in progress, please contact zhouqiang-cl,shuke987,jebter,you06 for more details.

@ti-srebot
Copy link
Contributor Author

@ti-srebot, please update your pull request.

1 similar comment
@ti-srebot
Copy link
Contributor Author

@ti-srebot, please update your pull request.

@ti-srebot
Copy link
Contributor Author

@ti-srebot PR closed due to no update for a long time. Feel free to reopen it anytime.

@ti-srebot ti-srebot closed this Jan 1, 2021
@Reminiscent
Copy link
Contributor

/reopen

@ti-chi-bot ti-chi-bot reopened this Mar 12, 2021
@ti-chi-bot
Copy link
Member

@Reminiscent: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2021
@Reminiscent
Merge branch 'release-4.0' of https://github.com/pingcap/tidb into ti…
0e85844 
…-srebot/release-4.0-2c66371d8b7e

� Conflicts:
�	bindinfo/bind_test.go
�	go.mod
�	infoschema/tables_test.go
@Reminiscent
fix conflicts
d07debf
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2021
@qw4990
Copy link
Contributor

qw4990 commented Mar 12, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d07debf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2021
@Reminiscent
Copy link
Contributor

/run-integration-copr-test

@qw4990 qw4990 merged commit 5edebf9 into pingcap:release-4.0 Mar 12, 2021
@zhouqiang-cl zhouqiang-cl modified the milestones: 4.0.0, v4.0.12 Mar 26, 2021
@qw4990 qw4990 mentioned this pull request Mar 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@qw4990 qw4990 qw4990 approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

Assignees

@Reminiscent Reminiscent

Labels
component/executor contribution This PR is from a community contributor. sig/execution SIG execution sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.12
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @Reminiscent @eurekaka @ti-chi-bot @qw4990 @zhouqiang-cl