expression, executor: allow insert strings with overflowed trailing spaces #20987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/reward 300 |
|
You are not the mentor for the linked issue. |
Closed
ichn-hu
force-pushed
the
fix-10392
branch
2 times, most recently
from
8960f12 to
b123478
Compare
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-integration-ddl-test |
|
/run-unit-test |
|
/cc @XuHuaiyu PTAL |
|
/cc @XuHuaiyu |
|
/run-all-tests |
|
@wshwsh12 PTALA |
|
/reward 300 |
|
This PR's linked issue is not picked. |
|
@XuHuaiyu I picked up the original issue, please reward again. |
|
@XuHuaiyu PTALA |
ti-srebot
approved these changes
Nov 24, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@ichn-hu merge failed. |
|
/run-all-tests |
|
/run-all-tests |
|
/run-unit-tests |
1 similar comment
|
/run-unit-tests |
|
/run-all-tests |
|
@ichn-hu, Congratulations, you get 300 in this PR, and your total score is 300 in high-performance challenge program. |
|
/label need-cherry-pick-4.0 |
|
These labels are not found |
|
/label needs-cherry-pick-4.0 |
|
/run-cherry-pick |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Nov 25, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #21282 |
ti-srebot
added a commit
that referenced
this pull request
Nov 25, 2020
…paces (#20987) (#21282) Signed-off-by: ti-srebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #10392
Problem Summary:
For now, TiDB will complain with error if string inserted are longer than
varcharorchar's lenght constraint with trailing spaces, however, as in MySQL's dochttps://dev.mysql.com/doc/refman/8.0/en/char.html
What is changed and how it works?
Make overflowed trailing spaces trimed, and report warning for
varchar.Proposal: xxx
What's Changed:
How it Works:
Related changes
Check List
Tests
Side effects
N/A
Release note