expression: add new scalar function IsTruthWithNull #19621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wshwsh12
requested review from
qw4990 and
winoros
and removed request for
a team
github-actions
bot
added
component/expression
sig/execution
wshwsh12
changed the title
|
PTAL @winoros @SunRunAway |
SunRunAway
reviewed
Sep 3, 2020
expression/builtin.go
Outdated
| ast.UnaryMinus: &unaryMinusFunctionClass{baseFunctionClass{ast.UnaryMinus, 1, 1}}, | ||
| ast.In: &inFunctionClass{baseFunctionClass{ast.In, 2, -1}}, | ||
| ast.IsTruth: &isTrueOrFalseFunctionClass{baseFunctionClass{ast.IsTruth, 1, 1}, opcode.IsTruth, false}, | ||
| ast.IsTruthWithNull: &isTrueOrFalseFunctionClass{baseFunctionClass{ast.IsTruthWithNull, 1, 1}, opcode.IsTruth, true}, |
There was a problem hiding this comment.
By expanding AST, all places of use of ast.IsTruth should also consider ast.IsTrueWithNull.
Is expanding the function signature more suitable comparing to expanding AST?
There was a problem hiding this comment.
I think the two ways are same... Expanding AST is necessary, expanding the function signature is optional...
|
Please resolve conflicts @wshwsh12 |
|
@wshwsh12 Please fix CI problems. |
|
/run-all-tests parser=pr/1016 |
|
/run-all-tests |
|
/run-unit-test |
ti-srebot
approved these changes
Sep 9, 2020
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 9, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-3.0 in PR #19901 |
|
cherry pick to release-4.0 in PR #19903 |
bb7133
pushed a commit
that referenced
this pull request
Sep 17, 2020
XuHuaiyu
pushed a commit
that referenced
this pull request
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17720, close #17476
Problem Summary: NewFunction can't get keepnull attributes for isture function.
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
Check List
Tests
Side effects
Release note