expression: add linear search for the interval function #19543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichn-hu
force-pushed
the
add-linear-search-for-interval
branch
from
4dca148 to
5d8dc02
Compare
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
@XuHuaiyu Hi Huaiyu~ PTAL~ |
|
@SunRunAway PTAL as well~ |
|
@XuHuaiyu @SunRunAway friendly ping~ |
|
/uncc @lzmhhh123 |
|
/cc @SunRunAway |
|
/cc @XuHuaiyu |
|
You can try to fix the coprocessor version. |
|
@XuHuaiyu PTAL |
XuHuaiyu
reviewed
Sep 2, 2020
XuHuaiyu
reviewed
Sep 2, 2020
ti-srebot
approved these changes
Sep 3, 2020
|
/merge |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
/run-all-tests |
|
@ichn-hu merge failed. |
|
/run-unit-test |
|
/run-integration-test |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 4, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-3.0 in PR #19789 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 4, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #19790 |
ti-srebot
added a commit
that referenced
this pull request
Sep 5, 2020
) Signed-off-by: ti-srebot <[email protected]>
SunRunAway
pushed a commit
that referenced
this pull request
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #18525
Problem Summary: due to the binary search algorithm for the
intervalfunction we currently employed can't handle NULL values correctly, it caused different result from MySQL. After research the MySQL's implementation for this function, I figured out that MySQL uses linear search if there is aNULLargument, therefore I added this functionality to ourintervalfunction.What is changed and how it works?
What's Changed: linear search is added for
intervalfunctions.How it Works: we use linear search instead of binary search if any of the argument might be NULL.
Related changes
Check List
Tests
Side effects
Release note