-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner,executor: enable plan cache for partition table #19124
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19124 +/- ##
===========================================
Coverage 79.1163% 79.1163%
===========================================
Files 547 547
Lines 148772 148772
===========================================
Hits 117703 117703
Misses 21606 21606
Partials 9463 9463 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eurekaka PTAL
it seems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it better to remove:
https://github.com/pingcap/tidb/blob/master/planner/core/common_plans.go#L444
https://github.com/pingcap/tidb/blob/master/planner/core/common_plans.go#L463
https://github.com/pingcap/tidb/blob/master/planner/core/common_plans.go#L478
https://github.com/pingcap/tidb/blob/master/planner/core/common_plans.go#L523
https://github.com/pingcap/tidb/blob/master/planner/core/common_plans.go#L535
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to add some new tests?
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
PTAL @winoros |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/rebuild |
/merge |
/run-all-tests |
@tiancaiamao merge failed. |
/merge |
/run-all-tests |
@tiancaiamao merge failed. |
/run-all-tests |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@tiancaiamao merge failed. |
/merge |
/run-all-tests |
What problem does this PR solve?
Problem Summary:
In the new implementation, queries on the partition table are not converted to UnionScan and partition pruning on in executor builder.
So it is possible to use plan cache for the partition table now.
This PR enables plan cache for the partition table.
What is changed and how it works?
What's Changed:
How it Works:
Revert part of the #16375
Check List
Tests
The old unit test
TestPrepareCacheForPartition
should cover the changes.Release note