executor: kill tableReader for each connection correctly (#18277) #18505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
|
/run-all-tests |
ti-srebot
added
sig/execution
|
@fzhedu please accept the invitation then you can push to the cherry-pick pull requests. |
|
/rebuild |
1 similar comment
|
/rebuild |
|
/run-unit-test |
ti-srebot
added
status/LGT2
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
SunRunAway
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18277 to release-4.0
What problem does this PR solve?
Issue Number: close a part of #18057
Problem Summary:
The tableReader in the coprocessor may retry many times to read regions, druing which, it cannot be aware of the cancelation from client. It may take much of memory for a long time.
What is changed and how it works?
Proposal: detect
Killedto stop the goroutine.What's Changed: should not use
CompareAndSwapto change theKilledbefore Close(), because many runninig goroutines should detect theKilled.How it Works: the TableReader the detect the
killedin every loop.The query may not exit quickly, because the query do some close work.
Check List
Tests
test on mocktikv:
similarly test on TiFlash is ok.
Release note