-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner, util: new unfixed mutrow for TypeNull (#17893) #17934
planner, util: new unfixed mutrow for TypeNull (#17893) #17934
Conversation
Signed-off-by: sre-bot <[email protected]>
/run-all-tests |
planner/core/integration_test.go
Outdated
@@ -252,3 +252,267 @@ func (s *testIntegrationSuite) TestIssue15813(c *C) { | |||
tk.MustExec("CREATE INDEX i0 ON t1(c0)") | |||
tk.MustQuery("select /*+ MERGE_JOIN(t0, t1) */ * from t0, t1 where t0.c0 = t1.c0").Check(testkit.Rows()) | |||
} | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XuHuaiyu
Please fix the conflict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-all-tests |
@sre-bot merge failed. |
/merge |
/run-all-tests |
@sre-bot merge failed. |
/merge |
/run-all-tests |
@sre-bot merge failed. |
/merge |
/run-all-tests |
@sre-bot merge failed. |
/merge |
/run-all-tests |
@sre-bot merge failed. |
/build |
/run-all-tests |
/merge |
/run-all-tests |
@sre-bot merge failed. |
/merge |
/run-all-tests |
@sre-bot merge failed. |
release-2.1 does not support |
/merge |
/run-all-tests |
cherry-pick #17893 to release-2.1
What problem does this PR solve?
Issue Number: close #16027 #6252
Problem Summary:
TypeNull should be handled as unfixedLen field type. refer MySQL: https://github.com/mysql/mysql-server/blob/8.0/sql/field.h#L151
What is changed and how it works?
What's Changed:
makeMutRowBytesColumn
fornil
How it Works:
The reason is mentioned in #15512 (comment).
Related changes
Check List
Tests
Side effects
N/A
Release note