expression: Fix the wrong behavior of const.String() #17495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reminiscent
added
type/bugfix
ghost
requested review from
Reminiscent
commented
May 29, 2020
|
|
||
| tk.MustExec("use test;") | ||
| tk.MustExec("drop table if exists t;") | ||
| tk.MustExec("set @@tidb_enable_vectorized_expression = false;") |
There was a problem hiding this comment.
Set this to test the behavior of const.Eval(). If we don't change the implementation of the const.Eval(). The following SQL statement will panic.
|
@SunRunAway PTAL |
Codecov Report
@@ Coverage Diff @@
## master #17495 +/- ##
===========================================
Coverage 79.4585% 79.4585%
===========================================
Files 524 524
Lines 141212 141212
===========================================
Hits 112205 112205
Misses 19948 19948
Partials 9059 9059 |
zz-jason
added
status/can-merge
|
/run-all-tests |
|
@Reminiscent merge failed. |
|
/merge |
|
/run-all-tests |
|
@Reminiscent merge failed. |
|
/merge |
|
/run-all-tests |
|
@Reminiscent merge failed. |
|
/merge |
1 similar comment
|
/merge |
|
/run-all-tests |
|
/run-all-tests |
|
@Reminiscent merge failed. |
|
/run-integration-br-test |
Please fix the release note as user perspective. |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 4, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-4.0 in PR #17673 |
SunRunAway
pushed a commit
that referenced
this pull request
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17287
Problem Summary:
const.String()is wrong.const.DeferredExpr != nil, we need to use the passed function parameterchunk.rowforEval, instead of using an emptychunk.Row.What is changed and how it works?
Use the
const.DeferredExpr.String()rather than to eval theconst.Use the function parameter
chunk.rowforEvalinstead of an emptychunk.Row().Related changes
Check List
Tests
Release note
preparestatement