Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix slow_query bug when query with time equal condition and in different time zone (#17082) #17164

Merged
merged 4 commits into from
May 14, 2020
Merged

executor: fix slow_query bug when query with time equal condition and in different time zone (#17082) #17164

merged 4 commits into from
May 14, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 13, 2020

cherry-pick #17082 to release-4.0

Signed-off-by: crazycs520 [email protected]

What problem does this PR solve?

As title said, Fix below problem:

mysql>set @@time_zone = '+00:00';
Query OK, 0 rows affected
Time: 0.001s
mysql>select time from slow_query limit 1;
+----------------------------+
| time                       |
+----------------------------+
| 2020-05-09 13:33:09.650837 |
+----------------------------+
1 row in set
Time: 0.010s
mysql>select time from slow_query where time='2020-05-09 13:33:09.650837';
+------+
| time |   -- should have at least 1 rows.
+------+
0 rows in set

What is changed and how it works?

Related changes

Check List

Tests

  • Unit test

Side effects

  • Breaking backward compatibility

Release note

  • Fix slow_query bug when query with time equal condition and in different time zone.

@sre-bot sre-bot requested a review from a team as a code owner May 13, 2020 06:37
@sre-bot
Copy link
Contributor Author

sre-bot commented May 13, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request May 13, 2020
Merged
@sre-bot sre-bot added sig/execution SIG execution type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels May 13, 2020
@sre-bot sre-bot added this to the 4.0.0-rc.2 milestone May 13, 2020
@ghost ghost removed their request for review May 13, 2020 06:37
@XuHuaiyu XuHuaiyu removed their request for review May 13, 2020 08:19
djshow832
djshow832 reviewed May 13, 2020
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Deardrops
Deardrops approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@Deardrops Deardrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels May 14, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

Your auto merge job has been accepted, waiting for:

  • 17118
  • 17107
  • 16165
  • 17003
  • 17126

@zz-jason zz-jason removed the request for review from AilinKid May 14, 2020 05:15
@sre-bot
Copy link
Contributor Author

sre-bot commented May 14, 2020

/run-all-tests

@sre-bot sre-bot merged commit 3e1d50e into pingcap:release-4.0 May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 left review comments

@Deardrops Deardrops Deardrops approved these changes

Assignees

@crazycs520 crazycs520

Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
4.0.0-rc.2
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @Deardrops @djshow832 @zz-jason @crazycs520