Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: fix case of stmt_type in statement summary (#17005) #17018

Merged
merged 2 commits into from
May 7, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 7, 2020

cherry-pick #17005 to release-4.0


What problem does this PR solve?

Problem Summary:
stmt_type was transformed to lower cases, so AlterTable was transformed to altertable, which was not readable.

What is changed and how it works?

What's Changed:
Do not transform stmt_type to lower case.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
mysql> truncate t;
Query OK, 0 rows affected (0.01 sec)

mysql> select stmt_type, digest_text from information_schema.statements_summary where stmt_type='TruncateTable';
+---------------+-------------+
| stmt_type     | digest_text |
+---------------+-------------+
| TruncateTable | truncate t  |
+---------------+-------------+
1 row in set (0.00 sec)

Side effects

  • Breaking backward compatibility

Release note

  • Change the case of field stmt_type in statement summary tables.

@sre-bot
Copy link
Contributor Author

sre-bot commented May 7, 2020

/run-all-tests

@sre-bot sre-bot added compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. sig/sql-infra SIG: SQL Infra component/infoschema type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels May 7, 2020
@sre-bot sre-bot requested review from AilinKid and Deardrops May 7, 2020 08:29
@sre-bot sre-bot added this to the v4.0.0-rc.1 milestone May 7, 2020
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Deardrops Deardrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label May 7, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 7, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented May 7, 2020

@sre-bot merge failed.

@zz-jason zz-jason merged commit 6870302 into pingcap:release-4.0 May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. component/infoschema sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants