Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: refine function accessPathsForConds to avoid wrong indexmerge plan (#16863) #16947

Merged
merged 5 commits into from
May 8, 2020
Merged

planner: refine function accessPathsForConds to avoid wrong indexmerge plan (#16863) #16947

merged 5 commits into from
May 8, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 30, 2020

cherry-pick #16863 to release-4.0

What problem does this PR solve?

Issue Number: close #16837

Problem Summary:

What is changed and how it works?

What's Changed:

  • Add function ConvertToIndexMergePath for to-do works.
  • Continue when we have no Accessconds and some TableFilter rules.

How it Works:

  • Avoid pushing table filter to the merged indexes.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • Fixed the bug that wrong index merge plans are generated for unique index.

@sre-bot sre-bot requested a review from a team as a code owner April 30, 2020 03:26
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 30, 2020

/run-all-tests

@ghost ghost requested a review from francis0407 April 30, 2020 03:26
@sre-bot sre-bot mentioned this pull request Apr 30, 2020
Merged
@sre-bot sre-bot added sig/planner SIG: Planner type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels Apr 30, 2020
@sre-bot sre-bot added this to the v4.0.0-rc.1 milestone Apr 30, 2020
@danmay319 danmay319 requested a review from eurekaka April 30, 2020 03:53
eurekaka
eurekaka reviewed Apr 30, 2020
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danmay319 danmay319 added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 30, 2020
@zhouqiang-cl
Copy link
Contributor

/rebuild

zz-jason
zz-jason approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 6, 2020
@zz-jason zz-jason removed request for winoros and francis0407 May 6, 2020 07:14
@sre-bot
Copy link
Contributor Author

sre-bot commented May 6, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented May 6, 2020

@sre-bot merge failed.

@danmay319
Copy link
Contributor

/run-all-tests

@danmay319
Copy link
Contributor

please merge @zz-jason @eurekaka

@zz-jason
Copy link
Member

zz-jason commented May 8, 2020

Fixed the bug that wrong index merge plans are generated for unique index.

please also describe the scenario which triggers the bug.

@eurekaka eurekaka merged commit 846c6f8 into pingcap:release-4.0 May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees

@danmay319 danmay319

Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @zhouqiang-cl @danmay319 @zz-jason @eurekaka