Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: make handshake packet read/write error log as debug (#16877) #16881

Merged
merged 3 commits into from
Apr 29, 2020
Merged

server: make handshake packet read/write error log as debug (#16877) #16881

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e566c0
server: let handshake packet read/write error log as debug (#16877)
lysu Apr 28, 2020
f1b3f26
Merge branch 'release-4.0' into release-4.0-2e144ef5f27b
sre-bot Apr 28, 2020
e60b558
Merge branch 'release-4.0' into release-4.0-2e144ef5f27b
ngaut Apr 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions server/conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,9 @@ func (cc *clientConn) String() string {
func (cc *clientConn) handshake(ctx context.Context) error {
if err := cc.writeInitialHandshake(); err != nil {
if errors.Cause(err) == io.EOF {
logutil.Logger(ctx).Info("Could not send handshake due to connection has be closed by client-side")
logutil.Logger(ctx).Debug("Could not send handshake due to connection has be closed by client-side")
} else {
terror.Log(err)
logutil.Logger(ctx).Debug("Write init handshake to client fail", zap.Error(errors.SuspendStack(err)))
}
return err
}
Expand Down Expand Up @@ -492,9 +492,9 @@ func (cc *clientConn) readOptionalSSLRequestAndHandshakeResponse(ctx context.Con
if err != nil {
err = errors.SuspendStack(err)
if errors.Cause(err) == io.EOF {
logutil.Logger(ctx).Info("wait handshake response fail due to connection has be closed by client-side")
logutil.Logger(ctx).Debug("wait handshake response fail due to connection has be closed by client-side")
} else {
logutil.Logger(ctx).Error("wait handshake response fail", zap.Error(err))
logutil.Logger(ctx).Debug("wait handshake response fail", zap.Error(err))
}
return err
}
Expand Down