*: support auto_random table option #16750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
github-actions
bot
added
sig/sql-infra
djshow832
reviewed
Apr 23, 2020
AilinKid
force-pushed
the
alter_auto_rand
branch
from
e5f79a0 to
20a1666
Compare
Codecov Report
@@ Coverage Diff @@
## master #16750 +/- ##
===========================================
Coverage 80.5344% 80.5344%
===========================================
Files 507 507
Lines 138491 138491
===========================================
Hits 111533 111533
Misses 18299 18299
Partials 8659 8659 |
bb7133
reviewed
Apr 24, 2020
zimulala
reviewed
Apr 24, 2020
infoschema/builder.go
Outdated
| @@ -74,7 +74,7 @@ func (b *Builder) ApplyDiff(m *meta.Meta, diff *model.SchemaDiff) ([]int64, erro | |||
| // We try to reuse the old allocator, so the cached auto ID can be reused. | |||
| var allocs autoid.Allocators | |||
| if tableIDIsValid(oldTableID) { | |||
| if oldTableID == newTableID && diff.Type != model.ActionRenameTable && diff.Type != model.ActionRebaseAutoID && diff.Type != model.ActionModifyTableAutoIdCache { | |||
| if oldTableID == newTableID && diff.Type != model.ActionRenameTable && diff.Type != model.ActionRebaseAutoID && diff.Type != model.ActionRebaseAutoRandomBase && diff.Type != model.ActionModifyTableAutoIdCache { | |||
There was a problem hiding this comment.
It seems that if we only rebase auto_random, but auto_id also rebase(we will clean the cache in TiDB).
There was a problem hiding this comment.
seems right. should keep the special allocator survive?
There was a problem hiding this comment.
Could we handle it？I think it feels confusing to users. And please add some tests.
|
/run-integration-copr-test |
|
/run-integration-common-test |
1 similar comment
|
/run-integration-common-test |
AilinKid
added
status/LGT2
|
/run-integration-common-test |
bb7133
added
needs-cherry-pick-3.1
require-LGT3
bb7133
added
status/LGT3
|
/run-all-tests |
|
@AilinKid merge failed. |
|
/run-integration-common-test |
bb7133
approved these changes
Apr 24, 2020
|
integration-common-test seems nothing to do with this PR, so we gonna merge it now |
|
cherry pick to release-3.1 in PR #16812 |
|
cherry pick to release-4.0 in PR #16813 |
AilinKid
added a commit
to sre-bot/tidb
that referenced
this pull request
Apr 26, 2020
Signed-off-by: sre-bot <[email protected]>
bb7133
pushed a commit
that referenced
this pull request
Apr 26, 2020
AilinKid
added a commit
to sre-bot/tidb
that referenced
this pull request
Apr 27, 2020
zimulala
pushed a commit
that referenced
this pull request
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary: support
auto_random_basetable option, this PR is related to issue pingcap/br#241What is changed and how it works?
How it Works:
After this table option:
We can do the auto_random rebase by
alter table xxx auto_random_base = numAlso we can specify the initial auto_random base by
create table t xxx(xxx) auto_random_base = numRelated changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note
support auto_random table option for rebase auto_random allocator