expression: return an error when finding some expressions cannot be pushed down to avoid panic #16671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
removed request for
Codecov Report
@@ Coverage Diff @@
## master #16671 +/- ##
================================================
- Coverage 80.5006% 80.3239% -0.1768%
================================================
Files 508 507 -1
Lines 139087 137375 -1712
================================================
- Hits 111966 110345 -1621
+ Misses 18462 18359 -103
- Partials 8659 8671 +12 |
|
/run-all-tests |
wjhuang2016
approved these changes
Apr 27, 2020
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 27, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-3.0 in PR #16867 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 27, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-3.1 in PR #16868 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 27, 2020
…ushed down to avoid panic (pingcap#16671)
|
cherry pick to release-4.0 in PR #16869 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: the first step to fix #16597
Problem Summary: in #16597, TiDB tries to convert some expressions which cannot be pushed down to
PBdata, which causes a panic.And we don't know which expression causes this problem.
What is changed and how it works?
When converting expressions to
PBdata, if it finds some expression cannot be pushed down, return an error with information of that expression.