planner: fix group by resolver for multi items with param marker #16363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfzjywxk
added
type/bugfix
ghost
removed their request for review
Codecov Report
@@ Coverage Diff @@
## master #16363 +/- ##
===========================================
Coverage 80.6297% 80.6297%
===========================================
Files 507 507
Lines 138336 138336
===========================================
Hits 111540 111540
Misses 18215 18215
Partials 8581 8581 |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@cfzjywxk merge failed. |
|
/run-all-tests |
|
cherry pick to release-4.0 in PR #16377 |
sre-bot
added a commit
that referenced
this pull request
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #16342
Problem Summary:
ParamMarker expressions in
group byclause are not processed properly, only the first one could be treated asPositionExprWhat is changed and how it works?
What's Changed:
Reset the
exprDepthbefore resolving each group itemHow it Works:
Related changes
Check List
Tests
Side effects
Release note